This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Revert named colors #345
Merged
Revert named colors #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change caused a startup-regression with Color because it spends time building up a dictionary as soon as the Color type is touched (in its static ctor). Changing this code back to use pattern-matching, which forces us to allocate a string, for now. Once we have a compiler that supports pattern-matching on a ReadOnlySpan<char>, we can do this allocation free. This is no worse than the original implementation, which also always allocated the lowered string to do pattern matching on.
jonlipsky
approved these changes
Mar 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change caused a startup-regression with Color because it spends time building up a dictionary as soon as the Color type is touched (in its static ctor). Changing this code back to use pattern-matching, which forces us to allocate a string, for now. Once we have a compiler that supports pattern-matching on a ReadOnlySpan, we can do this allocation free.
This is similar to the original implementation, which also always allocated the lowered string to do pattern matching on.
Here are my benchmark results.
Orig without any of my Color changes
PR
So you can see
ParseBlackis slightly slower than before. But when we get dotnet/csharplang#1881 it should be as fast, or faster, and allocation free.